ISerialization methods should take in const jsi::Value& (#56410)#56410
Closed
tsaichien wants to merge 1 commit intofacebook:mainfrom
Closed
ISerialization methods should take in const jsi::Value& (#56410)#56410tsaichien wants to merge 1 commit intofacebook:mainfrom
const jsi::Value& (#56410)#56410tsaichien wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100222030. |
meta-codesync
bot
changed the title
const jsi::Value&const jsi::Value& (#56410)
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Apr 9, 2026
…6410) Summary: Missed when we first added the `ISerialization` interface. In JSI APIs, `Value` is generally passed in as a const reference. This makes it clear that the actual reference, not the referent, is const. Fixing the serialization methods to be consistent with the rest of JSI. Changelog: [Internal] Differential Revision: D100222030
tsaichien
force-pushed
the
export-D100222030
branch
from
15dddfa to
e851957
Compare
…6410) Summary: Pull Request resolved: facebook#56410 Missed when we first added the `ISerialization` interface. In JSI APIs, `Value` is generally passed in as a const reference. This makes it clear that the actual reference, not the referent, is const. Fixing the serialization methods to be consistent with the rest of JSI. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D100222030
tsaichien
force-pushed
the
export-D100222030
branch
from
e851957 to
963a7b4
Compare
meta-codesync bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Apr 13, 2026
Summary: X-link: facebook/react-native#56410 Missed when we first added the `ISerialization` interface. In JSI APIs, `Value` is generally passed in as a const reference. This makes it clear that the actual reference, not the referent, is const. Fixing the serialization methods to be consistent with the rest of JSI. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D100222030 fbshipit-source-id: 2297d5c89b90db51269d216e6c3a822d9a4a93ab
meta-codesync bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Apr 13, 2026
Summary: X-link: facebook/react-native#56410 Missed when we first added the `ISerialization` interface. In JSI APIs, `Value` is generally passed in as a const reference. This makes it clear that the actual reference, not the referent, is const. Fixing the serialization methods to be consistent with the rest of JSI. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D100222030 fbshipit-source-id: 2297d5c89b90db51269d216e6c3a822d9a4a93ab
meta-codesync bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Apr 13, 2026
Summary: X-link: facebook/react-native#56410 Missed when we first added the `ISerialization` interface. In JSI APIs, `Value` is generally passed in as a const reference. This makes it clear that the actual reference, not the referent, is const. Fixing the serialization methods to be consistent with the rest of JSI. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D100222030 fbshipit-source-id: 2297d5c89b90db51269d216e6c3a822d9a4a93ab
|
This pull request has been merged in 36b3060. |
Collaborator
|
This pull request was successfully merged by @tsaichien in 36b3060 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Missed when we first added the
ISerializationinterface. In JSI APIs,Valueis generally passed in as a const reference. This makes it clearthat the actual reference, not the referent, is const.
Fixing the serialization methods to be consistent with the rest of JSI.
Changelog: [Internal]
Reviewed By: lavenzg
Differential Revision: D100222030